From a328c2cd4b16e409489440930c3562ed5242e80a Mon Sep 17 00:00:00 2001 From: Adam Spiers Date: Mon, 1 Apr 2024 01:55:31 +0100 Subject: [PATCH] t/stow: convert to subtests() --- t/stow.t | 884 +++++++++++++++++++++++++++---------------------------- 1 file changed, 434 insertions(+), 450 deletions(-) diff --git a/t/stow.t b/t/stow.t index 0563457..9e97b48 100755 --- a/t/stow.t +++ b/t/stow.t @@ -22,7 +22,7 @@ use strict; use warnings; -use Test::More tests => 118; +use Test::More tests => 21; use Test::Output; use English qw(-no_match_vars); @@ -37,520 +37,504 @@ my %conflicts; # Note that each of the following tests use a distinct set of files -# -# stow a simple tree minimally -# -$stow = new_Stow(dir => '../stow'); +subtest('stow a simple tree minimally', sub { + plan tests => 2; + my $stow = new_Stow(dir => '../stow'); -make_path('../stow/pkg1/bin1'); -make_file('../stow/pkg1/bin1/file1'); + make_path('../stow/pkg1/bin1'); + make_file('../stow/pkg1/bin1/file1'); -$stow->plan_stow('pkg1'); -$stow->process_tasks(); -is_deeply([ $stow->get_conflicts ], [], 'no conflicts with minimal stow'); -is( - readlink('bin1'), - '../stow/pkg1/bin1', - => 'minimal stow of a simple tree' -); - -# -# stow a simple tree into an existing directory -# -$stow = new_Stow(); - -make_path('../stow/pkg2/lib2'); -make_file('../stow/pkg2/lib2/file2'); -make_path('lib2'); - -$stow->plan_stow('pkg2'); -$stow->process_tasks(); -is( - readlink('lib2/file2'), - '../../stow/pkg2/lib2/file2', - => 'stow simple tree to existing directory' -); - -# -# unfold existing tree -# -$stow = new_Stow(); - -make_path('../stow/pkg3a/bin3'); -make_file('../stow/pkg3a/bin3/file3a'); -make_link('bin3' => '../stow/pkg3a/bin3'); # emulate stow - -make_path('../stow/pkg3b/bin3'); -make_file('../stow/pkg3b/bin3/file3b'); - -$stow->plan_stow('pkg3b'); -$stow->process_tasks(); -ok( - -d 'bin3' && - readlink('bin3/file3a') eq '../../stow/pkg3a/bin3/file3a' && - readlink('bin3/file3b') eq '../../stow/pkg3b/bin3/file3b' - => 'target already has 1 stowed package' -); - -# -# Link to a new dir 'bin4' conflicts with existing non-dir so can't -# unfold -# -$stow = new_Stow(); - -make_file('bin4'); # this is a file but named like a directory -make_path('../stow/pkg4/bin4'); -make_file('../stow/pkg4/bin4/file4'); - -$stow->plan_stow('pkg4'); -%conflicts = $stow->get_conflicts(); -ok( - $stow->get_conflict_count == 1 && - $conflicts{stow}{pkg4}[0] =~ - qr/existing target is neither a link nor a directory/ - => 'link to new dir bin4 conflicts with existing non-directory' -); - -# -# Link to a new dir 'bin4a' conflicts with existing non-dir so can't -# unfold even with --adopt -# -#$stow = new_Stow(adopt => 1); -$stow = new_Stow(); - -make_file('bin4a'); # this is a file but named like a directory -make_path('../stow/pkg4a/bin4a'); -make_file('../stow/pkg4a/bin4a/file4a'); - -$stow->plan_stow('pkg4a'); -%conflicts = $stow->get_conflicts(); -ok( - $stow->get_conflict_count == 1 && - $conflicts{stow}{pkg4a}[0] =~ - qr/existing target is neither a link nor a directory/ - => 'link to new dir bin4a conflicts with existing non-directory' -); - -# -# Link to files 'file4b' and 'bin4b' conflict with existing files -# without --adopt -# -$stow = new_Stow(); - -# Populate target -make_file('file4b', 'file4b - version originally in target'); -make_path ('bin4b'); -make_file('bin4b/file4b', 'bin4b/file4b - version originally in target'); - -# Populate -make_path ('../stow/pkg4b/bin4b'); -make_file('../stow/pkg4b/file4b', 'file4b - version originally in stow package'); -make_file('../stow/pkg4b/bin4b/file4b', 'bin4b/file4b - version originally in stow package'); - -$stow->plan_stow('pkg4b'); -%conflicts = $stow->get_conflicts(); -is($stow->get_conflict_count, 2 => 'conflict per file'); -for my $i (0, 1) { - like( - $conflicts{stow}{pkg4b}[$i], - qr/existing target is neither a link nor a directory/ - => 'link to file4b conflicts with existing non-directory' - ); -} - -# -# Link to files 'file4b' and 'bin4b' do not conflict with existing -# files when --adopt is given -# -$stow = new_Stow(adopt => 1); - -# Populate target -make_file('file4c', "file4c - version originally in target\n"); -make_path ('bin4c'); -make_file('bin4c/file4c', "bin4c/file4c - version originally in target\n"); - -# Populate -make_path ('../stow/pkg4c/bin4c'); -make_file('../stow/pkg4c/file4c', "file4c - version originally in stow package\n"); -make_file('../stow/pkg4c/bin4c/file4c', "bin4c/file4c - version originally in stow package\n"); - -$stow->plan_stow('pkg4c'); -is($stow->get_conflict_count, 0 => 'no conflicts with --adopt'); -is($stow->get_tasks, 4 => 'two tasks per file'); -$stow->process_tasks(); -for my $file ('file4c', 'bin4c/file4c') { - ok(-l $file, "$file turned into a symlink"); + $stow->plan_stow('pkg1'); + $stow->process_tasks(); + is_deeply([ $stow->get_conflicts ], [], 'no conflicts with minimal stow'); is( - readlink $file, - (index($file, '/') == -1 ? '' : '../' ) - . "../stow/pkg4c/$file" => "$file points to right place" + readlink('bin1'), + '../stow/pkg1/bin1', + => 'minimal stow of a simple tree' ); - is(cat_file($file), "$file - version originally in target\n" => "$file has right contents"); -} +}); +subtest('stow a simple tree into an existing directory', sub { + plan tests => 1; + my $stow = new_Stow(); -# -# Target already exists but is not owned by stow -# -$stow = new_Stow(); + make_path('../stow/pkg2/lib2'); + make_file('../stow/pkg2/lib2/file2'); + make_path('lib2'); -make_path('bin5'); -make_invalid_link('bin5/file5','../../empty'); -make_path('../stow/pkg5/bin5/file5'); + $stow->plan_stow('pkg2'); + $stow->process_tasks(); + is( + readlink('lib2/file2'), + '../../stow/pkg2/lib2/file2', + => 'stow simple tree to existing directory' + ); +}); -$stow->plan_stow('pkg5'); -%conflicts = $stow->get_conflicts(); -like( - $conflicts{stow}{pkg5}[-1], - qr/not owned by stow/ - => 'target already exists but is not owned by stow' -); +subtest('unfold existing tree', sub { + plan tests => 3; + my $stow = new_Stow(); -# -# Replace existing but invalid target -# -$stow = new_Stow(); + make_path('../stow/pkg3a/bin3'); + make_file('../stow/pkg3a/bin3/file3a'); + make_link('bin3' => '../stow/pkg3a/bin3'); # emulate stow -make_invalid_link('file6','../stow/path-does-not-exist'); -make_path('../stow/pkg6'); -make_file('../stow/pkg6/file6'); + make_path('../stow/pkg3b/bin3'); + make_file('../stow/pkg3b/bin3/file3b'); -$stow->plan_stow('pkg6'); -$stow->process_tasks(); -is( - readlink('file6'), - '../stow/pkg6/file6' - => 'replace existing but invalid target' -); + $stow->plan_stow('pkg3b'); + $stow->process_tasks(); + ok(-d 'bin3'); + is(readlink('bin3/file3a'), '../../stow/pkg3a/bin3/file3a'); + is(readlink('bin3/file3b'), '../../stow/pkg3b/bin3/file3b' + => 'target already has 1 stowed package'); +}); -# -# Target already exists, is owned by stow, but points to a non-directory -# (can't unfold) -# -$stow = new_Stow(); -#set_debug_level(4); +subtest("Link to a new dir 'bin4' conflicts with existing non-dir so can't unfold", sub { + plan tests => 2; + my $stow = new_Stow(); -make_path('bin7'); -make_path('../stow/pkg7a/bin7'); -make_file('../stow/pkg7a/bin7/node7'); -make_link('bin7/node7','../../stow/pkg7a/bin7/node7'); -make_path('../stow/pkg7b/bin7/node7'); -make_file('../stow/pkg7b/bin7/node7/file7'); + make_file('bin4'); # this is a file but named like a directory + make_path('../stow/pkg4/bin4'); + make_file('../stow/pkg4/bin4/file4'); -$stow->plan_stow('pkg7b'); -%conflicts = $stow->get_conflicts(); -like( - $conflicts{stow}{pkg7b}[-1], - qr/existing target is stowed to a different package/ - => 'link to new dir conflicts with existing stowed non-directory' -); + $stow->plan_stow('pkg4'); + %conflicts = $stow->get_conflicts(); + is($stow->get_conflict_count, 1); + ok($conflicts{stow}{pkg4}[0] =~ + qr/existing target is neither a link nor a directory/ + => 'link to new dir bin4 conflicts with existing non-directory' + ); +}); -# -# stowing directories named 0 -# -$stow = new_Stow(); +subtest("Link to a new dir 'bin4a' conflicts with existing non-dir " . + "so can't unfold even with --adopt", sub { + plan tests => 2; + #my $stow = new_Stow(adopt => 1); + my $stow = new_Stow(); -make_path('../stow/pkg8a/0'); -make_file('../stow/pkg8a/0/file8a'); -make_link('0' => '../stow/pkg8a/0'); # emulate stow + make_file('bin4a'); # this is a file but named like a directory + make_path('../stow/pkg4a/bin4a'); + make_file('../stow/pkg4a/bin4a/file4a'); -make_path('../stow/pkg8b/0'); -make_file('../stow/pkg8b/0/file8b'); + $stow->plan_stow('pkg4a'); + %conflicts = $stow->get_conflicts(); + is($stow->get_conflict_count, 1); + like($conflicts{stow}{pkg4a}[0], + qr/existing target is neither a link nor a directory/ + => 'link to new dir bin4a conflicts with existing non-directory' + ); +}); -$stow->plan_stow('pkg8b'); -$stow->process_tasks(); -ok( - $stow->get_conflict_count == 0 && - -d '0' && - readlink('0/file8a') eq '../../stow/pkg8a/0/file8a' && - readlink('0/file8b') eq '../../stow/pkg8b/0/file8b' - => 'stowing directories named 0' -); +subtest("Link to files 'file4b' and 'bin4b' conflict with existing files", sub { + plan tests => 3; + my $stow = new_Stow(); -# -# overriding already stowed documentation -# -$stow = new_Stow(override => ['man9', 'info9']); + # Populate target + make_file('file4b', 'file4b - version originally in target'); + make_path ('bin4b'); + make_file('bin4b/file4b', 'bin4b/file4b - version originally in target'); -make_path('../stow/pkg9a/man9/man1'); -make_file('../stow/pkg9a/man9/man1/file9.1'); -make_path('man9/man1'); -make_link('man9/man1/file9.1' => '../../../stow/pkg9a/man9/man1/file9.1'); # emulate stow + # Populate + make_path ('../stow/pkg4b/bin4b'); + make_file('../stow/pkg4b/file4b', 'file4b - version originally in stow package'); + make_file('../stow/pkg4b/bin4b/file4b', 'bin4b/file4b - version originally in stow package'); -make_path('../stow/pkg9b/man9/man1'); -make_file('../stow/pkg9b/man9/man1/file9.1'); + $stow->plan_stow('pkg4b'); + %conflicts = $stow->get_conflicts(); + is($stow->get_conflict_count, 2 => 'conflict per file'); + for my $i (0, 1) { + like( + $conflicts{stow}{pkg4b}[$i], + qr/existing target is neither a link nor a directory/ + => 'link to file4b conflicts with existing non-directory' + ); + } +}); -$stow->plan_stow('pkg9b'); -$stow->process_tasks(); -ok( - $stow->get_conflict_count == 0 && - readlink('man9/man1/file9.1') eq '../../../stow/pkg9b/man9/man1/file9.1' - => 'overriding existing documentation files' -); +subtest("Link to files 'file4b' and 'bin4b' do not conflict with existing", sub { + plan tests => 8; + my $stow = new_Stow(adopt => 1); -# -# deferring to already stowed documentation -# -$stow = new_Stow(defer => ['man10', 'info10']); + # Populate target + make_file('file4c', "file4c - version originally in target\n"); + make_path ('bin4c'); + make_file('bin4c/file4c', "bin4c/file4c - version originally in target\n"); -make_path('../stow/pkg10a/man10/man1'); -make_file('../stow/pkg10a/man10/man1/file10.1'); -make_path('man10/man1'); -make_link('man10/man1/file10.1' => '../../../stow/pkg10a/man10/man1/file10.1'); # emulate stow + # Populate + make_path ('../stow/pkg4c/bin4c'); + make_file('../stow/pkg4c/file4c', "file4c - version originally in stow package\n"); + make_file('../stow/pkg4c/bin4c/file4c', "bin4c/file4c - version originally in stow package\n"); -make_path('../stow/pkg10b/man10/man1'); -make_file('../stow/pkg10b/man10/man1/file10.1'); + $stow->plan_stow('pkg4c'); + is($stow->get_conflict_count, 0 => 'no conflicts with --adopt'); + is($stow->get_tasks, 4 => 'two tasks per file'); + $stow->process_tasks(); + for my $file ('file4c', 'bin4c/file4c') { + ok(-l $file, "$file turned into a symlink"); + is( + readlink $file, + (index($file, '/') == -1 ? '' : '../' ) + . "../stow/pkg4c/$file" => "$file points to right place" + ); + is(cat_file($file), "$file - version originally in target\n" => "$file has right contents"); + } -$stow->plan_stow('pkg10b'); -is($stow->get_tasks, 0, 'no tasks to process'); -ok( - $stow->get_conflict_count == 0 && - readlink('man10/man1/file10.1') eq '../../../stow/pkg10a/man10/man1/file10.1' - => 'defer to existing documentation files' -); +}); -# -# Ignore temp files -# -$stow = new_Stow(ignore => ['~', '\.#.*']); +subtest("Target already exists but is not owned by stow", sub { + plan tests => 1; + my $stow = new_Stow(); -make_path('../stow/pkg11/man11/man1'); -make_file('../stow/pkg11/man11/man1/file11.1'); -make_file('../stow/pkg11/man11/man1/file11.1~'); -make_file('../stow/pkg11/man11/man1/.#file11.1'); -make_path('man11/man1'); + make_path('bin5'); + make_invalid_link('bin5/file5','../../empty'); + make_path('../stow/pkg5/bin5/file5'); -$stow->plan_stow('pkg11'); -$stow->process_tasks(); -ok( - $stow->get_conflict_count == 0 && - readlink('man11/man1/file11.1') eq '../../../stow/pkg11/man11/man1/file11.1' && - !-e 'man11/man1/file11.1~' && - !-e 'man11/man1/.#file11.1' - => 'ignore temp files' -); + $stow->plan_stow('pkg5'); + %conflicts = $stow->get_conflicts(); + like( + $conflicts{stow}{pkg5}[-1], + qr/not owned by stow/ + => 'target already exists but is not owned by stow' + ); +}); -# -# stowing links library files -# -$stow = new_Stow(); +subtest("Replace existing but invalid target", sub { + plan tests => 1; + my $stow = new_Stow(); -make_path('../stow/pkg12/lib12/'); -make_file('../stow/pkg12/lib12/lib.so.1'); -make_link('../stow/pkg12/lib12/lib.so', 'lib.so.1'); + make_invalid_link('file6','../stow/path-does-not-exist'); + make_path('../stow/pkg6'); + make_file('../stow/pkg6/file6'); -make_path('lib12/'); + $stow->plan_stow('pkg6'); + $stow->process_tasks(); + is( + readlink('file6'), + '../stow/pkg6/file6' + => 'replace existing but invalid target' + ); +}); -$stow->plan_stow('pkg12'); -$stow->process_tasks(); -ok( - $stow->get_conflict_count == 0 && - readlink('lib12/lib.so.1') eq '../../stow/pkg12/lib12/lib.so.1' && - readlink('lib12/lib.so' ) eq '../../stow/pkg12/lib12/lib.so' - => 'stow links to libraries' -); +subtest("Target already exists, is owned by stow, but points to a non-directory", sub { + plan tests => 1; + my $stow = new_Stow(); + #set_debug_level(4); -# -# unfolding to stow links to library files -# -$stow = new_Stow(); + make_path('bin7'); + make_path('../stow/pkg7a/bin7'); + make_file('../stow/pkg7a/bin7/node7'); + make_link('bin7/node7','../../stow/pkg7a/bin7/node7'); + make_path('../stow/pkg7b/bin7/node7'); + make_file('../stow/pkg7b/bin7/node7/file7'); -make_path('../stow/pkg13a/lib13/'); -make_file('../stow/pkg13a/lib13/liba.so.1'); -make_link('../stow/pkg13a/lib13/liba.so', 'liba.so.1'); -make_link('lib13','../stow/pkg13a/lib13'); + $stow->plan_stow('pkg7b'); + %conflicts = $stow->get_conflicts(); + like( + $conflicts{stow}{pkg7b}[-1], + qr/existing target is stowed to a different package/ + => 'link to new dir conflicts with existing stowed non-directory' + ); +}); -make_path('../stow/pkg13b/lib13/'); -make_file('../stow/pkg13b/lib13/libb.so.1'); -make_link('../stow/pkg13b/lib13/libb.so', 'libb.so.1'); +subtest("stowing directories named 0", sub { + plan tests => 4; + my $stow = new_Stow(); -$stow->plan_stow('pkg13b'); -$stow->process_tasks(); -ok( - $stow->get_conflict_count == 0 && - readlink('lib13/liba.so.1') eq '../../stow/pkg13a/lib13/liba.so.1' && - readlink('lib13/liba.so' ) eq '../../stow/pkg13a/lib13/liba.so' && - readlink('lib13/libb.so.1') eq '../../stow/pkg13b/lib13/libb.so.1' && - readlink('lib13/libb.so' ) eq '../../stow/pkg13b/lib13/libb.so' - => 'unfolding to stow links to libraries' -); + make_path('../stow/pkg8a/0'); + make_file('../stow/pkg8a/0/file8a'); + make_link('0' => '../stow/pkg8a/0'); # emulate stow -# -# stowing to stow dir should fail -# -make_path('stow'); -$stow = new_Stow(dir => 'stow'); + make_path('../stow/pkg8b/0'); + make_file('../stow/pkg8b/0/file8b'); -make_path('stow/pkg14/stow/pkg15'); -make_file('stow/pkg14/stow/pkg15/node15'); + $stow->plan_stow('pkg8b'); + $stow->process_tasks(); + is($stow->get_conflict_count, 0); + ok(-d '0'); + is(readlink('0/file8a'), '../../stow/pkg8a/0/file8a'); + is(readlink('0/file8b'), '../../stow/pkg8b/0/file8b' + => 'stowing directories named 0' + ); +}); -capture_stderr(); -$stow->plan_stow('pkg14'); -is($stow->get_tasks, 0, 'no tasks to process'); -ok( - $stow->get_conflict_count == 0 && - ! -l 'stow/pkg15' - => "stowing to stow dir should fail" -); -like($stderr, - qr/WARNING: skipping target which was current stow directory stow/ - => "stowing to stow dir should give warning"); -uncapture_stderr(); +subtest("overriding already stowed documentation", sub { + plan tests => 2; + my $stow = new_Stow(override => ['man9', 'info9']); -# -# stow a simple tree minimally when cwd isn't target -# -cd('../..'); -$stow = new_Stow(dir => "$TEST_DIR/stow", target => "$TEST_DIR/target"); + make_path('../stow/pkg9a/man9/man1'); + make_file('../stow/pkg9a/man9/man1/file9.1'); + make_path('man9/man1'); + make_link('man9/man1/file9.1' => '../../../stow/pkg9a/man9/man1/file9.1'); # emulate stow -make_path("$TEST_DIR/stow/pkg16/bin16"); -make_file("$TEST_DIR/stow/pkg16/bin16/file16"); + make_path('../stow/pkg9b/man9/man1'); + make_file('../stow/pkg9b/man9/man1/file9.1'); -$stow->plan_stow('pkg16'); -$stow->process_tasks(); -is_deeply([ $stow->get_conflicts ], [], 'no conflicts with minimal stow'); -is( - readlink("$TEST_DIR/target/bin16"), - '../stow/pkg16/bin16', - => "minimal stow of a simple tree when cwd isn't target" -); + $stow->plan_stow('pkg9b'); + $stow->process_tasks(); + is($stow->get_conflict_count, 0); + is(readlink('man9/man1/file9.1'), '../../../stow/pkg9b/man9/man1/file9.1' + => 'overriding existing documentation files' + ); +}); -# -# stow a simple tree minimally to absolute stow dir when cwd isn't -# target -# -$stow = new_Stow(dir => canon_path("$TEST_DIR/stow"), - target => "$TEST_DIR/target"); +subtest("deferring to already stowed documentation", sub { + plan tests => 3; + my $stow = new_Stow(defer => ['man10', 'info10']); -make_path("$TEST_DIR/stow/pkg17/bin17"); -make_file("$TEST_DIR/stow/pkg17/bin17/file17"); + make_path('../stow/pkg10a/man10/man1'); + make_file('../stow/pkg10a/man10/man1/file10.1'); + make_path('man10/man1'); + make_link('man10/man1/file10.1' => '../../../stow/pkg10a/man10/man1/file10.1'); # emulate stow -$stow->plan_stow('pkg17'); -$stow->process_tasks(); -is_deeply([ $stow->get_conflicts ], [], 'no conflicts with minimal stow'); -is( - readlink("$TEST_DIR/target/bin17"), - '../stow/pkg17/bin17', - => "minimal stow of a simple tree with absolute stow dir" -); + make_path('../stow/pkg10b/man10/man1'); + make_file('../stow/pkg10b/man10/man1/file10.1'); -# -# stow a simple tree minimally with absolute stow AND target dirs when -# cwd isn't target -# -$stow = new_Stow(dir => canon_path("$TEST_DIR/stow"), - target => canon_path("$TEST_DIR/target")); + $stow->plan_stow('pkg10b'); + is($stow->get_tasks, 0, 'no tasks to process'); + is($stow->get_conflict_count, 0); + is(readlink('man10/man1/file10.1'), '../../../stow/pkg10a/man10/man1/file10.1' + => 'defer to existing documentation files' + ); +}); -make_path("$TEST_DIR/stow/pkg18/bin18"); -make_file("$TEST_DIR/stow/pkg18/bin18/file18"); +subtest("Ignore temp files", sub { + plan tests => 4; + my $stow = new_Stow(ignore => ['~', '\.#.*']); -$stow->plan_stow('pkg18'); -$stow->process_tasks(); -is_deeply([ $stow->get_conflicts ], [], 'no conflicts with minimal stow'); -is( - readlink("$TEST_DIR/target/bin18"), - '../stow/pkg18/bin18', - => "minimal stow of a simple tree with absolute stow and target dirs" -); + make_path('../stow/pkg11/man11/man1'); + make_file('../stow/pkg11/man11/man1/file11.1'); + make_file('../stow/pkg11/man11/man1/file11.1~'); + make_file('../stow/pkg11/man11/man1/.#file11.1'); + make_path('man11/man1'); -# -# stow a tree with no-folding enabled - -# no new folded directories should be created, and existing -# folded directories should be split open (unfolded) where -# (and only where) necessary -# -cd("$TEST_DIR/target"); + $stow->plan_stow('pkg11'); + $stow->process_tasks(); + is($stow->get_conflict_count, 0); + is(readlink('man11/man1/file11.1'), '../../../stow/pkg11/man11/man1/file11.1'); + ok(!-e 'man11/man1/file11.1~'); + ok(!-e 'man11/man1/.#file11.1' + => 'ignore temp files' + ); +}); -sub create_pkg { - my ($id, $pkg) = @_; +subtest("stowing links library files", sub { + plan tests => 3; + my $stow = new_Stow(); - my $stow_pkg = "../stow/$id-$pkg"; - make_path ($stow_pkg); - make_file("$stow_pkg/$id-file-$pkg"); + make_path('../stow/pkg12/lib12/'); + make_file('../stow/pkg12/lib12/lib.so.1'); + make_link('../stow/pkg12/lib12/lib.so', 'lib.so.1'); - # create a shallow hierarchy specific to this package which isn't - # yet stowed - make_path ("$stow_pkg/$id-$pkg-only-new"); - make_file("$stow_pkg/$id-$pkg-only-new/$id-file-$pkg"); + make_path('lib12/'); - # create a deeper hierarchy specific to this package which isn't - # yet stowed - make_path ("$stow_pkg/$id-$pkg-only-new2/subdir"); - make_file("$stow_pkg/$id-$pkg-only-new2/subdir/$id-file-$pkg"); - make_link("$stow_pkg/$id-$pkg-only-new2/current", "subdir"); + $stow->plan_stow('pkg12'); + $stow->process_tasks(); + is($stow->get_conflict_count, 0); + is(readlink('lib12/lib.so.1'), '../../stow/pkg12/lib12/lib.so.1'); + is(readlink('lib12/lib.so'), '../../stow/pkg12/lib12/lib.so' + => 'stow links to libraries' + ); +}); - # create a hierarchy specific to this package which is already - # stowed via a folded tree - make_path ("$stow_pkg/$id-$pkg-only-old"); - make_link("$id-$pkg-only-old", "$stow_pkg/$id-$pkg-only-old"); - make_file("$stow_pkg/$id-$pkg-only-old/$id-file-$pkg"); +subtest("unfolding to stow links to library files", sub { + plan tests => 5; + my $stow = new_Stow(); - # create a shared hierarchy which this package uses - make_path ("$stow_pkg/$id-shared"); - make_file("$stow_pkg/$id-shared/$id-file-$pkg"); + make_path('../stow/pkg13a/lib13/'); + make_file('../stow/pkg13a/lib13/liba.so.1'); + make_link('../stow/pkg13a/lib13/liba.so', 'liba.so.1'); + make_link('lib13','../stow/pkg13a/lib13'); - # create a partially shared hierarchy which this package uses - make_path ("$stow_pkg/$id-shared2/subdir-$pkg"); - make_file("$stow_pkg/$id-shared2/$id-file-$pkg"); - make_file("$stow_pkg/$id-shared2/subdir-$pkg/$id-file-$pkg"); -} + make_path('../stow/pkg13b/lib13/'); + make_file('../stow/pkg13b/lib13/libb.so.1'); + make_link('../stow/pkg13b/lib13/libb.so', 'libb.so.1'); -foreach my $pkg (qw{a b}) { - create_pkg('no-folding', $pkg); -} + $stow->plan_stow('pkg13b'); + $stow->process_tasks(); + is($stow->get_conflict_count, 0); + is(readlink('lib13/liba.so.1'), '../../stow/pkg13a/lib13/liba.so.1'); + is(readlink('lib13/liba.so' ), '../../stow/pkg13a/lib13/liba.so'); + is(readlink('lib13/libb.so.1'), '../../stow/pkg13b/lib13/libb.so.1'); + is(readlink('lib13/libb.so' ), '../../stow/pkg13b/lib13/libb.so' + => 'unfolding to stow links to libraries' + ); +}); -$stow = new_Stow('no-folding' => 1); -$stow->plan_stow('no-folding-a'); -is_deeply([ $stow->get_conflicts ], [] => 'no conflicts with --no-folding'); -my @tasks = $stow->get_tasks; -use Data::Dumper; -is(scalar(@tasks), 13 => "6 dirs, 7 links") || warn Dumper(\@tasks); -$stow->process_tasks(); +subtest("stowing to stow dir should fail", sub { + plan tests => 4; + make_path('stow'); + $stow = new_Stow(dir => 'stow'); -sub check_no_folding { - my ($pkg) = @_; - my $stow_pkg = "../stow/no-folding-$pkg"; - is_link("no-folding-file-$pkg", "$stow_pkg/no-folding-file-$pkg"); + make_path('stow/pkg14/stow/pkg15'); + make_file('stow/pkg14/stow/pkg15/node15'); - # check existing folded tree is untouched - is_link("no-folding-$pkg-only-old", "$stow_pkg/no-folding-$pkg-only-old"); + capture_stderr(); + $stow->plan_stow('pkg14'); + is($stow->get_tasks, 0, 'no tasks to process'); + is($stow->get_conflict_count, 0); + ok( + ! -l 'stow/pkg15' + => "stowing to stow dir should fail" + ); + like($stderr, + qr/WARNING: skipping target which was current stow directory stow/ + => "stowing to stow dir should give warning"); + uncapture_stderr(); +}); - # check newly stowed shallow tree is not folded - is_dir_not_symlink("no-folding-$pkg-only-new"); - is_link("no-folding-$pkg-only-new/no-folding-file-$pkg", - "../$stow_pkg/no-folding-$pkg-only-new/no-folding-file-$pkg"); +subtest("stow a simple tree minimally when cwd isn't target", sub { + plan tests => 2; + cd('../..'); + $stow = new_Stow(dir => "$TEST_DIR/stow", target => "$TEST_DIR/target"); - # check newly stowed deeper tree is not folded - is_dir_not_symlink("no-folding-$pkg-only-new2"); - is_dir_not_symlink("no-folding-$pkg-only-new2/subdir"); - is_link("no-folding-$pkg-only-new2/subdir/no-folding-file-$pkg", - "../../$stow_pkg/no-folding-$pkg-only-new2/subdir/no-folding-file-$pkg"); - is_link("no-folding-$pkg-only-new2/current", - "../$stow_pkg/no-folding-$pkg-only-new2/current"); + make_path("$TEST_DIR/stow/pkg16/bin16"); + make_file("$TEST_DIR/stow/pkg16/bin16/file16"); - # check shared tree is not folded. first time round this will be - # newly stowed. - is_dir_not_symlink('no-folding-shared'); - is_link("no-folding-shared/no-folding-file-$pkg", - "../$stow_pkg/no-folding-shared/no-folding-file-$pkg"); + $stow->plan_stow('pkg16'); + $stow->process_tasks(); + is_deeply([ $stow->get_conflicts ], [], 'no conflicts with minimal stow'); + is( + readlink("$TEST_DIR/target/bin16"), + '../stow/pkg16/bin16', + => "minimal stow of a simple tree when cwd isn't target" + ); +}); - # check partially shared tree is not folded. first time round this - # will be newly stowed. - is_dir_not_symlink('no-folding-shared2'); - is_link("no-folding-shared2/no-folding-file-$pkg", - "../$stow_pkg/no-folding-shared2/no-folding-file-$pkg"); - is_link("no-folding-shared2/no-folding-file-$pkg", - "../$stow_pkg/no-folding-shared2/no-folding-file-$pkg"); -} +subtest("stow a simple tree minimally to absolute stow dir when cwd isn't", sub { + plan tests => 2; + my $stow = new_Stow(dir => canon_path("$TEST_DIR/stow"), + target => "$TEST_DIR/target"); -check_no_folding('a'); + make_path("$TEST_DIR/stow/pkg17/bin17"); + make_file("$TEST_DIR/stow/pkg17/bin17/file17"); -$stow = new_Stow('no-folding' => 1); -$stow->plan_stow('no-folding-b'); -is_deeply([ $stow->get_conflicts ], [] => 'no conflicts with --no-folding'); -@tasks = $stow->get_tasks; -is(scalar(@tasks), 11 => '4 dirs, 7 links') || warn Dumper(\@tasks); -$stow->process_tasks(); + $stow->plan_stow('pkg17'); + $stow->process_tasks(); + is_deeply([ $stow->get_conflicts ], [], 'no conflicts with minimal stow'); + is( + readlink("$TEST_DIR/target/bin17"), + '../stow/pkg17/bin17', + => "minimal stow of a simple tree with absolute stow dir" + ); +}); -check_no_folding('a'); -check_no_folding('b'); +subtest("stow a simple tree minimally with absolute stow AND target dirs when", sub { + plan tests => 2; + my $stow = new_Stow(dir => canon_path("$TEST_DIR/stow"), + target => canon_path("$TEST_DIR/target")); + + make_path("$TEST_DIR/stow/pkg18/bin18"); + make_file("$TEST_DIR/stow/pkg18/bin18/file18"); + + $stow->plan_stow('pkg18'); + $stow->process_tasks(); + is_deeply([ $stow->get_conflicts ], [], 'no conflicts with minimal stow'); + is( + readlink("$TEST_DIR/target/bin18"), + '../stow/pkg18/bin18', + => "minimal stow of a simple tree with absolute stow and target dirs" + ); +}); + +subtest("stow a tree with no-folding enabled", sub { + plan tests => 82; + # folded directories should be split open (unfolded) where + # (and only where) necessary + # + cd("$TEST_DIR/target"); + + sub create_pkg { + my ($id, $pkg) = @_; + + my $stow_pkg = "../stow/$id-$pkg"; + make_path ($stow_pkg); + make_file("$stow_pkg/$id-file-$pkg"); + + # create a shallow hierarchy specific to this package which isn't + # yet stowed + make_path ("$stow_pkg/$id-$pkg-only-new"); + make_file("$stow_pkg/$id-$pkg-only-new/$id-file-$pkg"); + + # create a deeper hierarchy specific to this package which isn't + # yet stowed + make_path ("$stow_pkg/$id-$pkg-only-new2/subdir"); + make_file("$stow_pkg/$id-$pkg-only-new2/subdir/$id-file-$pkg"); + make_link("$stow_pkg/$id-$pkg-only-new2/current", "subdir"); + + # create a hierarchy specific to this package which is already + # stowed via a folded tree + make_path ("$stow_pkg/$id-$pkg-only-old"); + make_link("$id-$pkg-only-old", "$stow_pkg/$id-$pkg-only-old"); + make_file("$stow_pkg/$id-$pkg-only-old/$id-file-$pkg"); + + # create a shared hierarchy which this package uses + make_path ("$stow_pkg/$id-shared"); + make_file("$stow_pkg/$id-shared/$id-file-$pkg"); + + # create a partially shared hierarchy which this package uses + make_path ("$stow_pkg/$id-shared2/subdir-$pkg"); + make_file("$stow_pkg/$id-shared2/$id-file-$pkg"); + make_file("$stow_pkg/$id-shared2/subdir-$pkg/$id-file-$pkg"); + } + + foreach my $pkg (qw{a b}) { + create_pkg('no-folding', $pkg); + } + + $stow = new_Stow('no-folding' => 1); + $stow->plan_stow('no-folding-a'); + is_deeply([ $stow->get_conflicts ], [] => 'no conflicts with --no-folding'); + my @tasks = $stow->get_tasks; + use Data::Dumper; + is(scalar(@tasks), 13 => "6 dirs, 7 links") || warn Dumper(\@tasks); + $stow->process_tasks(); + + sub check_no_folding { + my ($pkg) = @_; + my $stow_pkg = "../stow/no-folding-$pkg"; + is_link("no-folding-file-$pkg", "$stow_pkg/no-folding-file-$pkg"); + + # check existing folded tree is untouched + is_link("no-folding-$pkg-only-old", "$stow_pkg/no-folding-$pkg-only-old"); + + # check newly stowed shallow tree is not folded + is_dir_not_symlink("no-folding-$pkg-only-new"); + is_link("no-folding-$pkg-only-new/no-folding-file-$pkg", + "../$stow_pkg/no-folding-$pkg-only-new/no-folding-file-$pkg"); + + # check newly stowed deeper tree is not folded + is_dir_not_symlink("no-folding-$pkg-only-new2"); + is_dir_not_symlink("no-folding-$pkg-only-new2/subdir"); + is_link("no-folding-$pkg-only-new2/subdir/no-folding-file-$pkg", + "../../$stow_pkg/no-folding-$pkg-only-new2/subdir/no-folding-file-$pkg"); + is_link("no-folding-$pkg-only-new2/current", + "../$stow_pkg/no-folding-$pkg-only-new2/current"); + + # check shared tree is not folded. first time round this will be + # newly stowed. + is_dir_not_symlink('no-folding-shared'); + is_link("no-folding-shared/no-folding-file-$pkg", + "../$stow_pkg/no-folding-shared/no-folding-file-$pkg"); + + # check partially shared tree is not folded. first time round this + # will be newly stowed. + is_dir_not_symlink('no-folding-shared2'); + is_link("no-folding-shared2/no-folding-file-$pkg", + "../$stow_pkg/no-folding-shared2/no-folding-file-$pkg"); + is_link("no-folding-shared2/no-folding-file-$pkg", + "../$stow_pkg/no-folding-shared2/no-folding-file-$pkg"); + } + + check_no_folding('a'); + + $stow = new_Stow('no-folding' => 1); + $stow->plan_stow('no-folding-b'); + is_deeply([ $stow->get_conflicts ], [] => 'no conflicts with --no-folding'); + @tasks = $stow->get_tasks; + is(scalar(@tasks), 11 => '4 dirs, 7 links') || warn Dumper(\@tasks); + $stow->process_tasks(); + + check_no_folding('a'); + check_no_folding('b'); +});