From 76496e7169c17ff1c72ef4921b4d93855f5f9810 Mon Sep 17 00:00:00 2001 From: Danielle McLean Date: Sun, 22 Aug 2021 23:08:45 +1000 Subject: [PATCH] Harmlessly ignore bad params to Libravatar I was throwing 400s when bad parameters are provided, but the spec actually says you're supposed to just ignore them entirely. --- users/views.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/users/views.py b/users/views.py index a73f347..2e700ee 100644 --- a/users/views.py +++ b/users/views.py @@ -21,9 +21,9 @@ def libravatar(request, hash): try: size = int(size) except ValueError: - return utils.bad_req('size parameter must be an integer') + size = 80 if not 1 <= size <= 512: - return utils.bad_req('size parameter must be between 1 and 512') + size = 512 if len(hash) == 32: where = Q(email_md5=hash)