00dani/lemoncurry
1
0
Fork 1
Code Issues Pull requests Releases Wiki Activity

Make the permalink views 404 if you try to load a non-existent entry

Browse source
This commit is contained in:
Danielle McLean 2018-03-08 14:13:45 +11:00
parent 756e3478d8
commit 039b6a1914
Signed by: 00dani
GPG key ID: 5A5D2D1AFF12EEC5
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
entries/views/perma.py
View file

@ -1,11 +1,11 @@
from annoying.decorators import render_to from annoying.decorators import render_to
from django.shortcuts import redirect from django.shortcuts import redirect, get_object_or_404
from ..models import Entry from ..models import Entry
@render_to('entries/entry.html') @render_to('entries/entry.html')
def entry(request, kind, id, slug=None): def entry(request, kind, id, slug=None):
entry = Entry.objects.get(pk=id) entry = get_object_or_404(Entry, pk=id)
if request.path != entry.url: if request.path != entry.url:
return redirect(entry.url, permanent=True) return redirect(entry.url, permanent=True)
return { return {
@ -17,7 +17,7 @@ def entry(request, kind, id, slug=None):
@render_to('entries/entry_amp.html') @render_to('entries/entry_amp.html')
def entry_amp(request, kind, id, slug=None): def entry_amp(request, kind, id, slug=None):
entry = Entry.objects.get(pk=id) entry = get_object_or_404(Entry, pk=id)
if request.path != entry.amp_url: if request.path != entry.amp_url:
return redirect(entry.amp_url, permanent=True) return redirect(entry.amp_url, permanent=True)
return {'entry': entry} return {'entry': entry}